Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CQT-115] PEP8 naming #369

Merged
merged 6 commits into from
Nov 7, 2024
Merged

[CQT-115] PEP8 naming #369

merged 6 commits into from
Nov 7, 2024

Conversation

GuyPuts
Copy link
Contributor

@GuyPuts GuyPuts commented Oct 30, 2024

Implements PEP8 styling convention, except for function names

@elenbaasc
Copy link
Collaborator

Hi Guy, thanks for looking at this.

Note that the pep8-naming option needs to be uncommented in the options of [tool.ruff.lint] in pyproject.toml, and then ruff needs to be run again (poetry run ruff check) to see if everything conforms to the pep8 naming standard.

To ignore pep8 naming (for instance for the gate names) you can add the noqa (no quality assurance) directive followed by the type (code) of ruff error to ignore, e.g.,
def H(q: QubitLike) -> BlochSphereRotation: # noqa: N802
Note that there are two spaces before the # and one space after (otherwise ruff format will complain) and that you need to run ruff to determine the codes (above is N802, to ignore Function names that should be lowercase.)

juanboschero
juanboschero previously approved these changes Nov 1, 2024
@elenbaasc elenbaasc dismissed juanboschero’s stale review November 5, 2024 12:40

Acceptance criteria of ticket have not been met yet.

@GuyPuts GuyPuts merged commit ec62dd2 into develop Nov 7, 2024
15 checks passed
@rturrado rturrado changed the title Cqt 115 pep8 naming [CQT-115] PEP8 naming Nov 8, 2024
@rturrado rturrado deleted the CQT-115-pep8-naming branch November 18, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants