AWS: don't process the management account twice #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's already a block for processing the management account. The Organizations call for listing accounts will however list also the top-level "root" account. They however don't have the OrganizationAccountAccessRole set up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's already a block for processing the management account at https://github.com/Qualys/totalcloud_resource_counter/blob/main/aws/aws-resource-counter.py#L343.
The current code will ask for account list from Org at https://github.com/Qualys/totalcloud_resource_counter/blob/main/aws/aws-resource-counter.py#L410, however that will also receive the id of the "management account" aka the root of the Organization. As they are not usually set up with the OrganizationAccountAccessRole it will lead to error in logs.
Even if it didn't, it's not really useful to count the same account twice.