Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sphinx Design tabs need other hover indicator other than just color change #79

Closed
Tracked by #72
gabalafou opened this issue May 28, 2024 · 4 comments
Closed
Tracked by #72

Sphinx Design tabs need other hover indicator other than just color change #79

gabalafou opened this issue May 28, 2024 · 4 comments
Assignees
@Carreau @smeragoel
Labels
area: accessibility ♿ area: PyData-Sphinx size: S A few hours, less than one week

Comments

@gabalafou
Copy link
Contributor

gabalafou commented May 28, 2024 •
edited
Loading

Perhaps underline?

The PyData Theme docs has an example of Sphinx Design tabs, where this issue can be checked.
@gabalafou gabalafou mentioned this issue May 28, 2024
Open
@gabalafou gabalafou changed the title Sphinx Design Tabs need other hover indicator other than just color change (underlining?) Sphinx Design Tabs need other hover indicator other than just color change May 28, 2024
@gabalafou gabalafou changed the title Sphinx Design Tabs need other hover indicator other than just color change Sphinx Design tabs need other hover indicator other than just color change May 28, 2024
@gabalafou
Copy link
Contributor Author

I need design to come up with the desired interaction and then I can implement.

@isabela-pf isabela-pf changed the title Sphinx Design tabs need other hover indicator other than just color change [S] Sphinx Design tabs need other hover indicator other than just color change May 30, 2024
@gabalafou gabalafou moved this from 📬 TODO to Design in czi-scientific-python 🐍 May 31, 2024
@gabalafou gabalafou added the size: S A few hours, less than one week label May 31, 2024
@gabalafou gabalafou changed the title [S] Sphinx Design tabs need other hover indicator other than just color change Sphinx Design tabs need other hover indicator other than just color change May 31, 2024
@smeragoel smeragoel self-assigned this May 31, 2024
@trallard trallard moved this from Design to 📬 TODO in czi-scientific-python 🐍 Jun 4, 2024
@smeragoel smeragoel moved this from 📬 TODO to 🏗 In progress in czi-scientific-python 🐍 Jun 10, 2024
@smeragoel
Copy link

Here's my design proposal:

We can add a simple underline like Gabriel suggested, and it would function akin to what we have in buttons right now.

Image

Here's a demo loom:

@smeragoel smeragoel moved this from 🏗 In progress to 👀 In review in czi-scientific-python 🐍 Jun 10, 2024
@trallard
Copy link
Member

Decided that an underline is good for the hover state.

@trallard trallard moved this from 👀 In review to 🏗 In progress in czi-scientific-python 🐍 Jun 13, 2024
@Carreau Carreau self-assigned this Jun 14, 2024
Carreau added a commit to Carreau/pydata-sphinx-theme that referenced this issue Jun 14, 2024
@Carreau
A11Y - Add visual indicator for tabs hover
27e4ea8 
Only changing color is not visually distinctive enough, adding an
underline with same size as link underline thickness.

See Quansight-Labs/czi-scientific-python-mgmt#79
@Carreau Carreau mentioned this issue Jun 14, 2024
Merged
@Carreau
Copy link
Contributor

Carreau commented Jun 14, 2024

See https://github.com/pydata/pydata-sphinx-theme#1884

trallard pushed a commit to pydata/pydata-sphinx-theme that referenced this issue Jun 15, 2024
@Carreau
A11Y - Add visual indicator for tabs hover (#1884)
09849cc 
Only changing color is not visually distinctive enough, adding an
underline with same size as link underline thickness.

See Quansight-Labs/czi-scientific-python-mgmt#79
@github-project-automation github-project-automation bot moved this from 🏗 In progress to 💪🏾 Done in czi-scientific-python 🐍 Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Carreau Carreau

@smeragoel smeragoel

Labels
area: accessibility ♿ area: PyData-Sphinx size: S A few hours, less than one week
Projects
czi-scientific-python 🐍
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gabalafou @Carreau @trallard @smeragoel