Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All the icon links in the nav bar are just a tiny bit too narrow (less than 24 css pixels) #94

Closed
Tracked by #72
gabalafou opened this issue May 28, 2024 · 0 comments
Closed
Tracked by #72

All the icon links in the nav bar are just a tiny bit too narrow (less than 24 css pixels) #94

gabalafou opened this issue May 28, 2024 · 0 comments
Labels
area: accessibility ♿ area: PyData-Sphinx size: S A few hours, less than one week

Comments

@gabalafou
Copy link
Contributor

No description provided.

@gabalafou gabalafou mentioned this issue May 28, 2024
Open
@gabalafou gabalafou changed the title All the icon links in the nav bar are just a tiny bit too narrow (less than 24 css pixels) [S] All the icon links in the nav bar are just a tiny bit too narrow (less than 24 css pixels) May 30, 2024
@gabalafou gabalafou moved this from 📬 TODO to Dev in czi-scientific-python 🐍 May 31, 2024
@gabalafou gabalafou added the size: S A few hours, less than one week label May 31, 2024
@gabalafou gabalafou moved this from Dev to 🏗 In progress in czi-scientific-python 🐍 May 31, 2024
@gabalafou gabalafou changed the title [S] All the icon links in the nav bar are just a tiny bit too narrow (less than 24 css pixels) All the icon links in the nav bar are just a tiny bit too narrow (less than 24 css pixels) Jun 4, 2024
@gabalafou gabalafou mentioned this issue Jun 5, 2024
Merged
Carreau pushed a commit to pydata/pydata-sphinx-theme that referenced this issue Jun 14, 2024
@gabalafou
Fix hit area icon links buttons (#1866)
4be630f 
Part of #1865.

Fixes external issue
Quansight-Labs/czi-scientific-python-mgmt#94.

This pull request started as a simple increase of the hit area for the
navbar icon links, but then I realized that with #1846 having been
merged, I could do a little bit of code cleanup at the same time.
@gabalafou gabalafou moved this from 🏗 In progress to 💪🏾 Done in czi-scientific-python 🐍 Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: accessibility ♿ area: PyData-Sphinx size: S A few hours, less than one week
Projects
czi-scientific-python 🐍
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabalafou @trallard