Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first pass at docs for porting extensions #15

Merged
merged 2 commits into from
May 21, 2024

Conversation

ngoldbaum
Copy link
Collaborator

Some of this is still stubbed out but I figured it's worth getting others to read this and maybe merged before I finish it.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@colesbury colesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! I'm working on a "HOWTO" for C-API extensions in the Python docs. I expect there will be some overlap with this document (which is fine).

README.md Outdated
python -c "import sysconfig; print(bool(sysconfig.get_config_var('Py_GIL_DISABLED')))"
```

And verify that the GIL is disabled at runtime with the following incantation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the easiest way is now to run python -VV which shows something like Python 3.13.0b1+ experimental free-threading build. This was added in the last week or so. It also shows up when you run the Python REPL.

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nitty comments here and there. Looks great otherwise! Thanks @ngoldbaum!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ngoldbaum
Copy link
Collaborator Author

Thanks all for reading this over!

@ngoldbaum ngoldbaum merged commit 0cb939a into Quansight-Labs:main May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants