Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUDIT - Main content area Zoom #9

Open
4 tasks done
Tracked by #7
trallard opened this issue Aug 2, 2022 · 3 comments
Open
4 tasks done
Tracked by #7

AUDIT - Main content area Zoom #9

trallard opened this issue Aug 2, 2022 · 3 comments

Comments

@trallard
Copy link
Member

trallard commented Aug 2, 2022

  • 200%
  • 400%
  • Change the default value of text size from 16 to 30 in the web browser
  • Test with different screen sizes

References

@steff456
Copy link
Contributor

steff456 commented Aug 9, 2022

These are the results of the Zoom Audit,

Behavior with sidebars opened

image

Python File behavior

image

Notebook behavior

image

Launcher behavior

image

Dialog behavior

image

Multiple tabs opened

image

Notebook toolbar in small screens or high zoom

image

Cell options in small screens or high zoom

image

Notes

  • The main content area is not visible or usable at 400% zoom if both sidebars are opened
  • Files are wrapping lines instead of having a horizontal scrollbar, which allows to see all the code without any action
  • If zoom is activated some filenames are not visible in the tabs, but hovering over them will give the complete information of the file
  • Opening a lot of files in zoom may cause to just seeing the icon and not being able to even close it
  • The notebook's toolbar is responsive and all the options are visible and usable
  • Cell options layout breaks with 400% zoom
  • Python logo in the launcher pixelates with zoom
  • The tab size height is fixed in px and it is a flex container where each tab just defines a z-index higher than the previous
  • Cell options height is fixed using the same value as the toolbar and it is a flex box
  • Dialogs occupy the complete interface with 400% zoom - the dialog panel is fixed in both width and height in px
  • The area in the container changes dynamically with the screen size and sidebars
  • Changing the default text size doesn't do any effect in Jlab UI, but changing the minimum text size in the browser does create changes.
  • The notebook view works with responsive layouts

Suggestions

  • In small screens or high zoom we should automatically close the sidebars and if opened they should take all the space to avoid users trying to use both at the same time.
  • A new UX/UI needs to be defined for the tabs in the main content area, especially the cases where too many of them are opened.
  • The cell options layout needs to be responsive - this may include removing options when the space is smaller or adding ellipsis.
  • Change the python logo to a new image that has better resolution
  • Dialogs sizes need to be checked for high zoom or small screens

@isabela-pf
Copy link

I'm following up on our tab discussion! I agreed that we needed some way to handle navigating tabs and had proposed a combo of

  1. Show only the current document's tab, the "+" for new launcher, and "…" to expand a list of all the tabs currently open. (Or something like that.)
  2. Add some kind of "jump to tab" button to each item in the the left sidebar's Running section. I believe all open documents (even if they don't have an attached kernel) are listed here, but I could be wrong about that.

But when I reviewed again today, I think both of these options already exist in some form. I was wrong! The Tabs menu does list open tabs (at the bottom of the menu, though, so I don't find it particularly quick to get to). The Running section also does open the selected document when clicked.

JupyterLab zoomed 400% with he Tabs menu open. The open tabs are listed at the bottom of the menu.

There still might be a way to optimize or make this clearer, but there is some support for tab navigation I missed. In particular, the many tabs situation that @steff456 shared a screen shot of above. My JuptyerLab switches to "simple mode" by default when scaled to this size, so tabs disappear. Maybe there needs to be a way to handle these tabs even outside of "simple mode?" Thoughts?

For records, I found this with a combo of

  • Operating System and version: MacOS Mojave
  • Browser and version: Firefox 103.0.2
  • JupyterLab version: 3.0.3

@steff456
Copy link
Contributor

There's some interesting findings here, I think that the behavior depends also in the decision we make with the flow of the main content area. In the case the sidebars are collapsed, we may need to have some way to access the list of tabs and the navigation feature (?) or we expect the user to use open the sidebar for this case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
Development

No branches or pull requests

3 participants