Remove tox configuration and use uv in Github Actions #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysnikolaou
force-pushed
the
remove-tox
branch
3 times, most recently
from
ec300f0 to
3715ce5
Compare
lysnikolaou
force-pushed
the
remove-tox
branch
from
3715ce5 to
ad708d0
Compare
ngoldbaum
reviewed
Oct 20, 2025
Contributor
There was a problem hiding this comment.
Makes sense. I like that this moves a bunch of configuration out of the pyproject.toml file. I don't really think it adds much to force everyone who wants to run the tests locally to use coverage.
There's also a "Contributing" section in the readme that mentions tox that needs to be updated. I'd include a suggested test command since now it's not so obvious how to get the coverage info.
.github/workflows/main.yml
Outdated
| python-version: ['3.9', '3.10', '3.11', '3.12', '3.13', '3.13t', '3.14', '3.14t'] | ||
| with-psutil: [false] | ||
| include: | ||
| - python-version: '3.13' |
Contributor
There was a problem hiding this comment.
Does this need to be running on 3.13 for some reason? Otherwise I'd move it to 3.14(t).
Member
|
👍🏼 from me as well
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if people are okay with using
uvon Github Actions. If not, I can always just usepipinstead.