Skip to content

Conversation

@lysnikolaou
Copy link
Member

No description provided.

@ngoldbaum
Copy link
Collaborator

Seems fine to me. We have branch protection turned on, right? I can't see the github actions config with my permissions.

What do you think about including these tests but excluding them from the list of actions that need to pass before PRs can be merged. That way these can break temporarily for whatever reason and it won't block us from fixing other stuff.

We could also mark the test steps in the jobs as continue-on-error but the github actions UI doesn't surface failures in a continue-on-error step very nicely so I tend to avoid it because you'll miss when the test breaks.

@lysnikolaou
Copy link
Member Author

lysnikolaou commented Nov 20, 2025

What do you think about including these tests but excluding them from the list of actions that need to pass before PRs can be merged. That way these can break temporarily for whatever reason and it won't block us from fixing other stuff.

Agreed. They're already optional.

I can't see the github actions config with my permissions.

I gave you admin permissions.

@lysnikolaou lysnikolaou merged commit e0c46c4 into Quansight-Labs:main Nov 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants