-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG - Broken staff member's display #470
Comments
Removing all of the project names for Consulting About Us will be a straightforward Storyblok content change, I will proceed to implement. 👍 On the other hand, after looking into it for a bit, I think removal of the Github logos is going to require code and Storyblok schema changes, when considered in combination with this feature request from #182:
This is due to an intersection of reasons:
(2) and (4) represent the core of the intractable problem for the Consulting site. If we define the username and profile for the user, it will cause the Github logo/link to render undesirably on the About Us page. If we do not define the username and profile for the user, it will prevent rendering of the author card as per #182. I think the most robust and workable solution would be to add a boolean Another possible solution would be to modify the WDYT, @trallard? |
Right now in https://quansight.com/about-us the Leadership team looks like this:
The only person with a GitHub icon (+link) is Ralf which looks pretty terrible. This has to be removed from the Leadership profiles.
Second - We now have a mixture of folks with projects listed under the GitHub icon and some others without. Which is expected because not everyone work on OSS projects. This also looks pretty inconsistent so I'd suggest removing this altogether to enable consistency. Like in the original Figma design, else everything is going to remain pretty inconsistent.
The text was updated successfully, but these errors were encountered: