-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Attributing multiple authors to a single blog post #182
Comments
This is also an issue with Labs blog, for example #278. Copying comment from @trallard in Slack:
|
@gabalafou Will LLC and Labs blogs be able to share a single implementation of this, or will the fixes be different? If the latter, should we perhaps split this issue in two? |
During the sprint planning call on 2022-09-19 with @bskinn, @kherma and @tokordys, we preliminarily decided on the following visual layout for the rendering of multiple authors. Each author will have the same "card" as in the current single-author configuration: avatar, Github handle, and name: For sufficiently wide layouts (desktop, and perhaps some tablets):
Now that I lay this out, it looks like rows of four author cards might work. The catch is in the case of authors with longer names. I don't know if React is smart enough to switch from four-per-row to three-per-row in cases where four-per-row is too wide for the space. For sufficiently narrow layouts (mobile, and perhaps some tablets), author cards will be stacked in a single column, vertically. While this may leave some conspicuous whitespace on the right hand side of the author card area, due to the variation in length of potential blog author names, it seems more complicated than it's worth to try to juggle a gridded card layout here. Again, though, if React is smart enough to be able to switch between a two-per-row and a one-per-row layout depending on the width of the content, that might be a nice way to implement. @noatamir / @trallard / @rgommers -- thoughts please w.r.t. Labs We are planning to hold off working on this issue until after #396 is completed (conversion of LLC blog to Github/Markdown machinery); so, we have time to iterate on the design decisions here. Thanks! |
That all sounds very reasonable to me, thanks. I'll note that most of our current issues with authors having gone missing is for two-author posts, so if this feature gets complicated due to regridding of many-author posts, you may consider solving the two-author issue first. |
Great point. We might even be YAGNI for a design considering more than three authors? |
I count zero posts in the LLC archive, and four (out of 56) posts in the Labs archive (based on the Notion board), which have 4+ authors. |
There is another visual styling question that must be decided: How to handle multiple authors on the blog gallery pages (Labs | LLC). The suggestion from the sprint planning meeting is to only explicitly include the first author on the post. In the case of multiple authors, their authorship will be represented by a "+ # others" annotation in the card for the post. Regardless of the author count, the post date will be advanced to the next line, left-justified. For example, for Labs (this post might not actually have multiple authors, I just grabbed one ~at random.): And for LLC: |
Agree this all sounds reasonable (including the re
The problematic part for me is the GitHub handle - right now it is plain text and not a link so technically useless It would be best if this were actually a link (with the correct styling) and we could prepend with an |
Agreed, it should be a link, and more obviously associated with Github. I like your proposal, @trallard. Separately, now that I'm looking closely, I think the vertical alignment of the GH handle and author name vis a vis the headshot also needs to be fixed -- they look like they're placed too low: |
@bskinn I just want to confirm before starting implementation. cc @gabalafou |
This is something we can discuss with @gabalafou, but yes, my intention would be that it would affect the rest of the posts. I envision that part of a PR for this would require converting all of the existing post |
Doable. But I haven't seen it implemented yet in the current t blog
https://quansight.com/library?page=1&type=blog
*Irina Fumarel*Graphic Designer
*Quansight* | Your Data Experts
m: +40 734 358 049
w: www.quansight.com e: ***@***.***
<https://www.linkedin.com/company/quansight>
<https://twitter.com/quansightai>
…On Wed, Sep 21, 2022 at 12:32 AM Brian Skinn ***@***.***> wrote:
During the sprint planning call on 2022-09-19 with @bskinn
<https://github.com/bskinn>, @kherma <https://github.com/kherma> and
@tokordys <https://github.com/tokordys>, we preliminarily decided on the
following visual layout for the rendering of multiple authors.
------------------------------
Each author will have the same "card" as in the current single-author
configuration: avatar, Github handle, and name:
[image: image]
<https://user-images.githubusercontent.com/11325439/191362695-8e20704b-94d1-4c28-9d27-63a3ae31a852.png>
------------------------------
For sufficiently wide layouts (desktop, and perhaps some tablets):
- Authors will be laid out in a grid, with three authors per grid row.
- The overall grid width will vary depending on the length of the
names of the authors.
- In most cases, the author grid will not span the full width of
the page text.
- The widths of the grid columns will also vary depending on the
widths of the author cards on that post.
- All columns should have the same width, however
- For rows that do not have three authors, the author cards will fill
the grid row starting from the left.
[image: image]
<https://user-images.githubusercontent.com/11325439/191366951-a7facb26-9454-47e8-a628-66844da28dc9.png>
*Now that I lay this out*, it looks like rows of *four* author cards
*might* work. The catch is in the case of authors with longer names. I
don't know if React is smart enough to switch from four-per-row to
three-per-row in cases where four-per-row is too wide for the space.
------------------------------
For sufficiently narrow layouts (mobile, and perhaps some tablets), author
cards will be stacked in a single column, vertically.
While this may leave some conspicuous whitespace on the right hand side of
the author card area, due to the variation in length of potential blog
author names, it seems more complicated than it's worth to try to juggle a
gridded card layout here.
Again, if React is smart enough to be able to switch between a two-per-row
and a one-per-row layout depending on the width of the content, that might
be a nice way to implement.
[image: image]
<https://user-images.githubusercontent.com/11325439/191366799-69d99430-8aeb-4cea-8c21-b40b98f660a4.png>
------------------------------
@noatamir <https://github.com/noatamir> / @trallard
<https://github.com/trallard> / @rgommers <https://github.com/rgommers>
-- thoughts please w.r.t. Labs
@Katebrack <https://github.com/Katebrack> -- thoughts please w.r.t. LLC
@irinafumarel <https://github.com/irinafumarel> / @MarsBarLee
<https://github.com/MarsBarLee> -- thoughts please w.r.t. general design
We are planning to hold off working on this issue until after #396
<#396> is completed
(conversion of LLC blog to Github/Markdown machinery); so, we have time to
iterate on the design decisions here.
Thanks!
—
Reply to this email directly, view it on GitHub
<#182 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATJJ6WB5RHKCKOFMB2AXIH3V7IUQNANCNFSM5YNZCQYA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I think that in YAML the no-brackets notation, My hunch is that it would be better if we match the YAML syntax as closely as possible to the structure of the data, meaning we should use the square brackets. Unless there is some really compelling argument to the contrary. |
Correct, @irinafumarel, this hasn't been implemented yet for either Jamstack site. We're going to be implementing it for Labs on Jamstack. This will be a separate discussion/activity from anything we might do for Consulting on Wordpress. I know we want to have multiple authors on the Consulting blog posts, if we can, but it's not something that has to be implemented by this weekend. |
That's what I thought as well, but I wasn't sure. And, agreed, unless there's a very strong reason not to use the array syntax, I think we should make it an array. |
No description provided.
The text was updated successfully, but these errors were encountered: