Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix omniscidb import #76

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Fix omniscidb import #76

merged 1 commit into from
Nov 16, 2020

Conversation

xmnlab
Copy link
Contributor

@xmnlab xmnlab commented Nov 13, 2020 •
edited
Loading

This PR aims to prepare the code and the notebooks to work with the new ibis version 1.4

Resolves #75

This PR:

  • Fixes build issues:
  • Fixes test issues
    • set browserExecutablePath just when OS is Darwin
    • updates and add test data (chart images)
    • fixes test parameter
  • Fixes CI issues
    • changes "goanpeca/setup-miniconda@v1" to "conda-incubator/setup-miniconda@v2"
  • Fixes ibis import (using the new package structure eg: from ibis.backends import omniscidb)

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@xmnlab xmnlab force-pushed the fix-omniscidb-import branch from 4ea3745 to ae4ba69 Compare November 16, 2020 01:29
@xmnlab xmnlab marked this pull request as ready for review November 16, 2020 01:47
@xmnlab xmnlab requested a review from goanpeca November 16, 2020 01:47
kcpevey
kcpevey approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@kcpevey kcpevey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a look since this may affect an issue I'm having. LGTM.

@xmnlab
Copy link
Contributor Author

xmnlab commented Nov 16, 2020

PS: after this PR is merged, we need a new release on pypi.

@xmnlab xmnlab merged commit 5e32970 into Quansight:master Nov 16, 2020
@xmnlab xmnlab deleted the fix-omniscidb-import branch November 16, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcpevey kcpevey kcpevey approved these changes

@goanpeca goanpeca Awaiting requested review from goanpeca

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ibis-Omnisci import syntax
2 participants
@xmnlab @kcpevey