-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable GPU profiles for GCP/AWS #1219
Conversation
This re-enables Profiles with GPU support, I think we should also include in this PR the jupyterhub version bump, as the GPU global settings issue #1201 might show during unexpected circumstances:
Those messages was originated from the conda-store worker pod after it was |
The reason I opted for
instead of a simples bool conditional to enable the daemon was to keep a standard to what was done with AWS provider. We can change that later if needed. |
This should not be merged until:
|
In hold for #1227 |
Just found a bug, pushing the fix right away |
In hold for quota increase to test AWS |
Fixes | Closes | Resolves #1209
Changes introduced in this PR:
03-kubernetes-initialize
stage, for Nvidia driver daemonsetgpu_node_group_names
to validatecount
for daemonset resourceguest_accelerators
Types of changes
What types of changes does your PR introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests?
Further comments (optional)
Tested the GPU was available in the profile executing
nvidia-smi