Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jupyterhub version to 2.2.2 #1227

Closed
wants to merge 1 commit into from
Closed

Conversation

viniciusdc
Copy link
Contributor

Fixes | Closes | Resolves #1201

Changes introduced in this PR:

  • Bump Jupyterhub version to 2.2.2

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@viniciusdc viniciusdc added type: enhancement 💅🏼 New feature or request needs: review 👀 This PR is complete and ready for reviewing area: user experience 👩🏻‍💻 status: in progress 🏗 This task is currently being worked on labels Apr 5, 2022
@viniciusdc viniciusdc requested review from danlester and costrouc April 5, 2022 15:09
@danlester
Copy link
Contributor

Yes, I haven't tried this out yet but I think it is unlikely that dashboards will be accessible to anyone other than the author.

Others have reported problems, due to new RBAC permissions in JupyterHub 2.0+: ideonate/cdsdashboards#96 - I haven't seen a simple solution presented though. It would need some understanding of how the new RBAC works.

@danlester
Copy link
Contributor

@viniciusdc Did you reach any conclusion on dashboard sharing? I can (and will) try it out for myself but also want to avoid being the only person who touches anything to do with dashboards!

@viniciusdc
Copy link
Contributor Author

@viniciusdc Did you reach any conclusion on dashboard sharing? I can (and will) try it out for myself but also want to avoid being the only person who touches anything to do with dashboards!

Hi Dan, sorry couldn't check that yet. If you have some extra time to show me a little about the dashboards configuration, I can help you too 😄

@viniciusdc
Copy link
Contributor Author

Quick update, as @danlester commented there is a change in the permission system for the dashboards (actually the whole jupyterhub ecosystem), which now works based on roles. So, I will read through this new system to look for a solution

@viniciusdc viniciusdc mentioned this pull request Apr 19, 2022
12 tasks
@magsol magsol added this to the Future Planning milestone Apr 26, 2022
@costrouc
Copy link
Member

This issue / PR is blocked until CDSDashboards properly supports jupyterhub 2.x

@viniciusdc
Copy link
Contributor Author

viniciusdc commented May 24, 2022

closing this in reason of #1292, as we are moving some configuration for cdsdashboards permission system.

@viniciusdc viniciusdc closed this May 24, 2022
@viniciusdc viniciusdc deleted the fix-1201-kubespawner branch August 18, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: user experience 👩🏻‍💻 needs: review 👀 This PR is complete and ready for reviewing status: in progress 🏗 This task is currently being worked on type: enhancement 💅🏼 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - kubespawner_overrides end up influencing future profile launches
4 participants