Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor PR to implement a faster version of
gridmake
as well as implement a mutating version.Also added some tests.
NOTE: this is breaking because previously we had the first array varying the fastest, now we have the last array varying the fastest. I don't believe this should cause problems for anyone, but if it does let me know and we'll do the other implementation.
A quick benchmark comparison:
Here
gridmake
is the new version andgridmake1
is the old version. This scales better and better the larger the input arrays.