QuantEcon.ecdf calls StatsBase.ecdf

[a-parida12]

Fixes #186

[sglyon]

Thank you @a-parida12, this is the right direction.

However I noticed that the tests are failing.

Here's my proposal for how to get them working again:

1. still include("ecdf.jl") in QuantEcon.jl
2. Delete everything that is currently in ecdf.jl
3. In ecdf.jl, write the necessary code so that existing usage of QuantEcon.ECDF doesn't throw an error (as it does in the tests). I think this means writing a single line like @deprecate ECDF(x) StatsBase.ecdf(x)
4. Change usage of ECDF to ecdf.jl in test/test_ecdf.jl
5. Re-run the tests to make sure they pass.

Are you comfortable giving that a shot?

[sglyon]

Let's also replace these two lines with

using StatsBase: ecdf

This will make Julia only bring that one function from the StatsBase module into scope inside QuantEcon, helping us avoid cluttering up our namespace.

[sglyon]

The last thing we need to do is add StatsBase to the REQUIRE file

[codecov-io]

Codecov Report

Merging #196 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage    90.8%   90.72%   -0.08%     
==========================================
  Files          24       24              
  Lines        1631     1682      +51     
==========================================
+ Hits         1481     1526      +45     
- Misses        150      156       +6

Impacted Files	Coverage Δ
src/modeltools/types.jl	87.23% <0%> (ø)
src/markov/markov_approx.jl	94.91% <0%> (+0.2%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11069d3...957c956. Read the comment docs.

[a-parida12]

Hi @sglyon,
Thank you for all the suggestion. I still have problems with codecov/project check which failed.

[sglyon]

Looks good to me.

Thank you