Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMPAT: Use cholesky for cholfact #214

Merged
merged 1 commit into from
Aug 11, 2018
Merged

COMPAT: Use cholesky for cholfact #214

merged 1 commit into from
Aug 11, 2018

Conversation

oyamad
Copy link
Member

@oyamad oyamad commented Aug 10, 2018

To have MVNSampler work in v0.7 by avoiding RankDeficientException (used in Games.jl).

@codecov-io
Copy link

codecov-io commented Aug 10, 2018

Codecov Report

Merging #214 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   90.93%   90.93%   +<.01%     
==========================================
  Files          25       25              
  Lines        1776     1777       +1     
==========================================
+ Hits         1615     1616       +1     
  Misses        161      161
Impacted Files Coverage Δ
src/sampler.jl 96.42% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0edda46...3c21f01. Read the comment docs.

@sglyon
Copy link
Member

sglyon commented Aug 11, 2018

Thank you!

@sglyon sglyon merged commit bd15e83 into master Aug 11, 2018
@oyamad oyamad deleted the cholesky branch August 11, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants