New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default value and change variable name of discrete_approximation #277

Merged

sglyon merged 1 commit into QuantEcon:master from Shunsuke-Hori:fix-discrete-approximation

Jul 23, 2022

Collaborator

Shunsuke-Hori commented Jul 23, 2022

Default value wasn't properly set.
- N was not defined.
- Tbar was not defined (though TBar was defined).
I set initial value more explicitly by using length(D)
I renamed TBar into Tbar. I think it's better as a variable that represents $\overline{T}$.


fix default value and change variable name

4bae192

Shunsuke-Hori added the ready label

Collaborator Author

Shunsuke-Hori commented Jul 23, 2022 •

edited

Loading

It's ready for a review. Would anyone be able to review this PR? (I wasn't sure if the "ready" label means ready for review or ready for merge.)

sglyon merged commit 2c43597 into QuantEcon:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment