Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional numba installation code #246

Closed
wants to merge 30 commits into from
Closed

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Mar 21, 2016

This PR removes code that was written to support environments that did't have numba installed. Now that numba is a strict dependency of the package - this code can now be removed. This will simplify how code is written etc.

Updates:

  1. markov/gth_solve should we remove the following given support for Python 3.5+:
+#-TODO: Remove as we no longer support Python <3.5?
+try:
+    xrange
+except:  # python3
+    xrange = range
  1. gth_solve so as not to change the code to much, I have added a use_jit header to the function signature to allow one to optionally use numpy. @oyamad Is this ok?

Deprecations:

  1. The numba_installed package wide variable is no longer available.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.967% when pulling 2d3aa9a on remove-optional-numba into b0cb89a on master.

@oyamad
Copy link
Member

oyamad commented Mar 23, 2016

@mmcky Yes, please remove the try-except block, and use_jit is fine with me.

@mmcky
Copy link
Contributor Author

mmcky commented Mar 23, 2016

@oyamad Thanks - I removed the try-except block and updated xrange to range in the functions.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 85.954% when pulling f32e468 on remove-optional-numba into b0cb89a on master.

@cc7768 cc7768 mentioned this pull request Apr 6, 2016
2 tasks
* DiscreteDP: Allow beta=1

* DiscreteDP: Add test_ddp_beta_1_not_implemented_error

* DiscreteDP: Remove util.numba_installed

* ddp: Add backward_induction

* ddp: Add test_backward_induction

* Minor edit in docstring

* Minor fix in docstring [ci skip]

* Minor edit: v[t] -> v[t, :] etc

just to be explicit

* Terminal value option: v_T -> v_term
- Change *_components to return labels
- Remove get_*_components
- Change *_classes to return values
- Remove get_*_classes
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 86.667% when pulling d4861b2 on remove-optional-numba into b0cb89a on master.

@mmcky
Copy link
Contributor Author

mmcky commented Apr 14, 2016

Looking at the diff this re-base doesn't look right. I will be closing this PR and implementing the simpler set of changes that remove the code that supported optional numba.

@mmcky mmcky closed this Apr 14, 2016
@mmcky mmcky deleted the remove-optional-numba branch April 14, 2016 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants