-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove optional numba installation code #246
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properties return indices as before
@mmcky Yes, please remove the |
@oyamad Thanks - I removed the |
and remove `return_values` from `simulate`
* DiscreteDP: Allow beta=1 * DiscreteDP: Add test_ddp_beta_1_not_implemented_error * DiscreteDP: Remove util.numba_installed * ddp: Add backward_induction * ddp: Add test_backward_induction * Minor edit in docstring * Minor fix in docstring [ci skip] * Minor edit: v[t] -> v[t, :] etc just to be explicit * Terminal value option: v_T -> v_term
Test should fail for this commit
- Change *_components to return labels - Remove get_*_components
- Change *_classes to return values - Remove get_*_classes
- Add simulate_indices which return indices
Add states/nodes to MarkovChain/DiGraph
Looking at the diff this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes code that was written to support environments that did't have
numba
installed. Now thatnumba
is a strict dependency of the package - this code can now be removed. This will simplify how code is written etc.Updates:
markov/gth_solve
should we remove the following given support for Python 3.5+:gth_solve
so as not to change the code to much, I have added ause_jit
header to the function signature to allow one to optionally use numpy. @oyamad Is this ok?Deprecations:
numba_installed
package wide variable is no longer available.