Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simplex_grid and simplex_index #344

Merged
merged 3 commits into from
Oct 1, 2017
Merged

Add simplex_grid and simplex_index #344

merged 3 commits into from
Oct 1, 2017

Conversation

oyamad
Copy link
Member

@oyamad oyamad commented Sep 27, 2017

From my old code https://github.com/oyamad/simplex_grid.
To be used in game_theory.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 93.033% when pulling 37ff345 on simplex_grid into ecbf2b2 on master.

@mmcky
Copy link
Contributor

mmcky commented Sep 28, 2017

@oyamad do you know why coverage has decreased with this PR? It looks like there are tests that should cover the additional routines.

@oyamad
Copy link
Member Author

oyamad commented Sep 28, 2017

It is because of the @jit decorator. It seems that a jitted function is not covered even without nopython=True.

@mmcky
Copy link
Contributor

mmcky commented Sep 28, 2017

ah - I should add the simple case for .coveragerc

Currently we have:

    # Don't count Numba nopython=True jit functions
    @jit\(.*nopython=True
    @njit

@mmcky
Copy link
Contributor

mmcky commented Sep 28, 2017

is there a reason not to use njit?

@oyamad
Copy link
Member Author

oyamad commented Sep 28, 2017

Because num_compositions is not jitted which uses scipy.misc.comb.

I could have implemented scipy.misc.comb with Numba, but I decided not to because it is not really necessary (@jit just works fine) and it is a nontrivial job to handle overflow.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 93.924% when pulling 4b527f0 on simplex_grid into ecbf2b2 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants