Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tac, toc, loop_timer to return float #387

Merged
merged 2 commits into from
Feb 6, 2018
Merged

Fix tac, toc, loop_timer to return float #387

merged 2 commits into from
Feb 6, 2018

Conversation

oyamad
Copy link
Member

@oyamad oyamad commented Feb 3, 2018

Close #386

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0007%) to 94.908% when pulling f49bd9b on tac_toc into f0dc490 on master.

@oyamad oyamad added the ready label Feb 3, 2018
@mmcky
Copy link
Contributor

mmcky commented Feb 4, 2018

@oyamad from a backwards compatibility perspective are there any changes to usage?
I don't think so as I see you've used verbose=True as a default so the floats will print.

@mmcky
Copy link
Contributor

mmcky commented Feb 4, 2018

thanks @oyamad this looks good.

@oyamad
Copy link
Member Author

oyamad commented Feb 5, 2018

Yes, this is backward incompatible:

Version Output type Print option Output option
-0.3.6.2 float - -
0.3.7 str or None print_output output
This PR float verbose -

@mmcky
Copy link
Contributor

mmcky commented Feb 5, 2018

@oyamad thanks. This is mainly used as a utility so I think that is fine. I will just do a search across the repo to make sure there are no other changes.

@mmcky mmcky merged commit 53261bd into master Feb 6, 2018
@mmcky mmcky deleted the tac_toc branch February 6, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants