Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Raise correct error when A is not square in LinearStateSpace #475

Merged
merged 1 commit into from
Mar 15, 2019

Conversation

QBatista
Copy link
Member

Currently:

A = np.zeros((1, 2))
C = np.zeros((1, 1))
G = np.zeros((1, 1))

qe.LinearStateSpace(A, C, G)

raises

TypeError: not all arguments converted during string formatting

This PR fixes lss.py so that the correct error is raised when A is not a square matrix.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 93.91% when pulling fc629de on QBatista:fix_error_lss into 1e757ec on QuantEcon:master.

Copy link
Member

@oyamad oyamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oyamad oyamad merged commit 2402749 into QuantEcon:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants