Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General cleanup of Package #515

Merged
merged 13 commits into from
Nov 5, 2019
Merged

General cleanup of Package #515

merged 13 commits into from
Nov 5, 2019

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Nov 4, 2019

this fixes #410

@mmcky mmcky added the in-work label Nov 4, 2019
@coveralls
Copy link

coveralls commented Nov 5, 2019

Coverage Status

Coverage decreased (-0.0009%) to 94.084% when pulling 0caabc7 on tidy-up into bdc61ff on master.

@pep8speaks
Copy link

pep8speaks commented Nov 5, 2019

Hello @mmcky! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-05 01:29:43 UTC

@oyamad oyamad mentioned this pull request Nov 5, 2019
6 tasks
@oyamad
Copy link
Member

oyamad commented Nov 5, 2019

Maybe add \n to this line:

doc += "\nversion = '%s'" % VERSION

    doc += "\nversion = '%s'\n" % VERSION

@mmcky mmcky requested a review from oyamad November 5, 2019 01:22
@mmcky mmcky added ready and removed in-work labels Nov 5, 2019
@mmcky
Copy link
Contributor Author

mmcky commented Nov 5, 2019

@oyamad I think this address all the items listed in #410. Thanks for adding those issues there.

In addition to the issue:

  1. I have removed data/ from the root level and migrated the only used file employment.csv to quantecon/tests/data
  2. swapped over to solely use setuptools
  3. added package discovery using find_packages()
  4. added MANIFEST.in for data inclusions.

@mmcky mmcky merged commit ad70e0e into master Nov 5, 2019
@mmcky mmcky deleted the tidy-up branch November 5, 2019 02:18
@mmcky mmcky restored the tidy-up branch November 5, 2019 02:18
@mmcky
Copy link
Contributor Author

mmcky commented Nov 5, 2019

shoot I should have squashed and merged. @oyamad would you mind if I made this the default?

@mmcky mmcky deleted the tidy-up branch November 5, 2019 02:20
@oyamad
Copy link
Member

oyamad commented Nov 5, 2019

No problem.

@mmcky mmcky mentioned this pull request Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup of QuantEcon.py - November
4 participants