Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub Actions] Setup Tests via Github Actions #561

Merged
merged 19 commits into from
Jan 2, 2021

Conversation

rht
Copy link
Contributor

@rht rht commented Jan 1, 2021

No description provided.

still need to add test changes for this to work
@rht
Copy link
Contributor Author

rht commented Jan 1, 2021

(whoops, I was about to make this PR on my fork instead of here!)
Oh well, anyway, since travis-ci.org is gone, we need to switch to another CI.

@rht rht force-pushed the test-action branch 3 times, most recently from 9f7a40f to 006ff0a Compare January 1, 2021 09:00
@rht
Copy link
Contributor Author

rht commented Jan 1, 2021

@Harveyt47 @mmcky I finally got 94.15% from coveralls.io: https://github.com/QuantEcon/QuantEcon.py/pull/561/checks?check_run_id=1633166620#step:7:15 -> https://coveralls.io/jobs/72880434.

@rht
Copy link
Contributor Author

rht commented Jan 1, 2021

My fix is to do according to this comment: coverallsapp/github-action#4 (comment).

@rht
Copy link
Contributor Author

rht commented Jan 1, 2021

Let me know if the commits need to be squashed. They are kind of messy.

@coveralls
Copy link

coveralls commented Jan 1, 2021

Coverage Status

Coverage increased (+0.1%) to 94.17% when pulling d8c4400 on rht:test-action into 08a15f5 on QuantEcon:master.

@mmcky mmcky changed the title Test action [GitHub Actions] Setup Tests via Github Actions Jan 1, 2021
@mmcky
Copy link
Contributor

mmcky commented Jan 1, 2021

thanks @rht!. We will definitely Squash these commits. One question before we merge -- I see you added a GitHub Repo Secret for the Tokens Coveralls. Just wondering if we should use a quantecon account -- I am guessing that is a personal token?

@rht
Copy link
Contributor Author

rht commented Jan 1, 2021

I see you added a GitHub Repo Secret for the Tokens Coveralls.

Nope, I was in fact removing it.
According to the readme of https://github.com/AndreMiras/coveralls-python-action
this is the default value of GITHUB_TOKEN:

Default: ${{ github.token }}

@rht
Copy link
Contributor Author

rht commented Jan 1, 2021

Also, I removed .coveralls.yml instead, so it is no longer tied to travis-ci.

@rht
Copy link
Contributor Author

rht commented Jan 1, 2021

I added another commit to remove pytest since it is no longer used in the latest version of this PR.

@Harveyt47
Copy link
Member

Harveyt47 commented Jan 1, 2021

Thanks @rht I struggled with the coveralls.io a bit. Is this still running nose and not pytest?

@rht
Copy link
Contributor Author

rht commented Jan 1, 2021

Yes, this is still running nose. If you want to migrate to pytest, I think we can do that in another PR.

@rht
Copy link
Contributor Author

rht commented Jan 1, 2021

Ready to be squashed.

@mmcky
Copy link
Contributor

mmcky commented Jan 2, 2021

Thanks @rht -- it will be nice to have tests via GitHub Actions.

@mmcky mmcky merged commit 128ed39 into QuantEcon:master Jan 2, 2021
@rht rht deleted the test-action branch January 2, 2021 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants