-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry add ivp solver #71
Conversation
be my first test case for IVP class.
This looks great!! How did you get 54 of these commits in? @jstac, once travis responds that all is well I think this should (finally 😄) be ready to merge. |
Not sure where all of that history came from...I checked out the most recent version of the three files from |
@spencerlyon2 As far as I am concerned this is ready for a merge. I could always tinker with the examples notebook, but I have probably reached the point of diminishing returns. Does @jstac need to weigh in? |
@davidrpugh, yes I agree. This is ready to go. We will wait for @jstac to take a look, but I imagine this will be merged soon. |
@davidrpugh @spencerlyon2 |
Let's try that again @davidrpugh @spencerlyon2 Thanks for the heroic effort. I hope you at least learned some useful stuff with all that wrestling with git. |
This all looks great. The notebook is excellent. The exposition is very nice now. We'll feature it on the new QuantEcon site when it goes up in a week or two. I'll go ahead and merge. The following are suggestions for small improvements that you can implement post-merge or ignore as you see fit:
|
@spencerlyon2 Hopefully we are all set!