Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linear_equations] Translation #10

Merged
merged 11 commits into from
Sep 27, 2024
Merged

[linear_equations] Translation #10

merged 11 commits into from
Sep 27, 2024

Conversation

longye-tian
Copy link
Contributor

Hi all @mmcky @HumphreyYang @SylviaZhaooo ,

I have translated the lecture linear_equations.md and put the translated version in the lecture folder.

Best,
Longye

Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for playful-platypus-17d3bb ready!

Name Link
🔨 Latest commit 9e534a3
🔍 Latest deploy log https://app.netlify.com/sites/playful-platypus-17d3bb/deploys/66f539a2f919d400081970c4
😎 Deploy Preview https://deploy-preview-10--playful-platypus-17d3bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Sep 16, 2024

@github-actions github-actions bot temporarily deployed to pull request September 16, 2024 02:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 16, 2024 06:48 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 16, 2024 06:48 Inactive
@mmcky
Copy link
Contributor

mmcky commented Sep 24, 2024

@longye-tian this build is failing due to

/home/runner/work/lecture-intro.zh-cn/lecture-intro.zh-cn/lectures/linear_equations.md:806: WARNING: equation not found: la_se2

are you able to look this up to see what might be the issue?

@mmcky
Copy link
Contributor

mmcky commented Sep 26, 2024

@longye-tian I gave this PR a go to see if some white space suggestions seem to fix the equation issue.

@mmcky
Copy link
Contributor

mmcky commented Sep 26, 2024

Equations are definitely buggy in the translations.

The build is now reporting

/home/runner/work/lecture-intro.zh-cn/lecture-intro.zh-cn/lectures/linear_equations.md:858: WARNING: equation not found: la_se2
/home/runner/work/lecture-intro.zh-cn/lecture-intro.zh-cn/lectures/linear_equations.md:902: WARNING: equation not found: two_eq_demand_mat
/home/runner/work/lecture-intro.zh-cn/lecture-intro.zh-cn/lectures/linear_equations.md:902: WARNING: equation not found: two_eq_supply_mat

I wonder if its a mix of math directives and using $$ math syntax.

I will do some more tests tomorrow unless anyone else has good ideas.

@github-actions github-actions bot temporarily deployed to pull request September 26, 2024 10:17 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 26, 2024 10:17 Inactive
@longye-tian
Copy link
Contributor Author

Equations are definitely buggy in the translations.

The build is now reporting

/home/runner/work/lecture-intro.zh-cn/lecture-intro.zh-cn/lectures/linear_equations.md:858: WARNING: equation not found: la_se2
/home/runner/work/lecture-intro.zh-cn/lecture-intro.zh-cn/lectures/linear_equations.md:902: WARNING: equation not found: two_eq_demand_mat
/home/runner/work/lecture-intro.zh-cn/lecture-intro.zh-cn/lectures/linear_equations.md:902: WARNING: equation not found: two_eq_supply_mat

I wonder if its a mix of math directives and using $$ math syntax.

I will do some more tests tomorrow unless anyone else has good ideas.

Hi Matt @mmcky ,

Just add more empty lines.
Now I think it works.

Best,
Longye

@@ -668,25 +734,32 @@ $$
```{math}
:label: two_matrix

p = (C - D)^{-1} h.
p = (C - D)^{-1} h.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@longye-tian these indentations shouldn't be needed. Do you add them for style?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change it back. I think I put too much space after the : label:

Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @longye-tian -- it seems there needs to be white space around the :label: keys

@github-actions github-actions bot temporarily deployed to pull request September 26, 2024 10:55 Inactive
@github-actions github-actions bot temporarily deployed to pull request September 26, 2024 10:55 Inactive
@mmcky mmcky merged commit 8ce6e95 into main Sep 27, 2024
7 checks passed
@mmcky mmcky deleted the linear_equations branch September 27, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants