Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix obvious bugs across all lectures #95

Merged
merged 5 commits into from
Oct 10, 2024
Merged

[bug] Fix obvious bugs across all lectures #95

merged 5 commits into from
Oct 10, 2024

Conversation

HumphreyYang
Copy link
Contributor

Hi @mmcky,

I spent some time hovering over all the lectures and fixing obvious bugs I spotted.

Please kindly merge this if it looks good.

Fixes #62
Fixes #73
Fixes #65

Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for playful-platypus-17d3bb ready!

Name Link
🔨 Latest commit 05731e2
🔍 Latest deploy log https://app.netlify.com/sites/playful-platypus-17d3bb/deploys/67070cc53706e100085a1074
😎 Deploy Preview https://deploy-preview-95--playful-platypus-17d3bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Oct 9, 2024

@github-actions github-actions bot temporarily deployed to pull request October 9, 2024 23:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 9, 2024 23:25 Inactive
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @HumphreyYang - thank you. I'd like to get this merged as it touches a lot of files. Does it address any of the issues (i.e. titles) -- just be nice to link them if it does. Thanks.

@@ -366,7 +366,7 @@ $$
以及

$$
\Sigma_y = \tilde A (\σ_u^2 I_{T \times T} ) \tilde A^T
\Sigma_y = \tilde A (\sigma_u^2 I_{T \times T} ) \tilde A^T
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HumphreyYang should these be unicode sigma?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just left this as a question.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @mmcky, I think this is correct under the latex environment: )

@mmcky
Copy link
Contributor

mmcky commented Oct 10, 2024

@HumphreyYang I see the fixes lines now. Thanks.

@mmcky mmcky merged commit 6964bf3 into main Oct 10, 2024
8 checks passed
@mmcky mmcky deleted the bug-fix branch October 10, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants