Fix NumPy 2.0 compatibility: Replace deprecated np.asfarray with np.asarray #230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a NumPy 2.0 compatibility issue in the AMSS lectures where
np.asfarraywas removed in NumPy 2.0.Problem
The code in
lectures/_static/lecture_specific/amss2/recursive_allocation.pyusesnp.asfarray()which was deprecated and removed in NumPy 2.0. This causes the following error when running the amss2 and amss3 lectures with NumPy 2.0+:Both amss2 and amss3 lectures are affected since they use the same
RecursiveAllocationAMSSclass.Solution
Replaced the deprecated
np.asfarray(x)with the functionally equivalentnp.asarray(x, dtype=float)on line 233 of therecursive_allocation.pyfile.Before:
After:
Testing
np.asfarrayexist in the codebaseThis is a minimal, surgical fix that maintains exact functional equivalence while ensuring forward compatibility with NumPy 2.0+.
Fixes #224.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.