Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Short term fix for ipywidgets #32

Closed
wants to merge 5 commits into from
Closed

FIX: Short term fix for ipywidgets #32

wants to merge 5 commits into from

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Apr 20, 2021

This PR is a short term fix to improve outputs in lectures that use ipywidgets.

  • matsuyama
  • black_litterman

This edits the lecture to show what the output should look like (with default values) and then leaves mybinder for the interactive plot. This is added as comments to the code with a link to the tracking issue to support richer ipywidgets in the html if possible as a future project.

@github-actions github-actions bot temporarily deployed to commit April 20, 2021 03:37 Inactive
@github-actions github-actions bot temporarily deployed to commit April 20, 2021 03:52 Inactive
@mmcky mmcky requested a review from jstac April 20, 2021 03:56
@mmcky
Copy link
Contributor Author

mmcky commented Apr 20, 2021

@jstac this is my proposal for ipywidgets in the short/medium term -- let me know what you think when you have time. thanks!

@mmcky
Copy link
Contributor Author

mmcky commented Apr 23, 2021

ipywidgets are actually breaking the website rendering as it injects javascript that doesn't run properly and so javascript halts rendering of the site.

  • I think we need to add interact to a :tags: ["remove-output"] code-cell and leave it to run in binder and local settings (for download notebooks). This will test that the cell executes but will remove any failed javascript objects

@github-actions github-actions bot temporarily deployed to commit April 23, 2021 04:05 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Apr 23, 2021

  • merged these changes into fix-codefromfiles branch to fix rendering issues when building with execution switched on

If there are no further changes this won't need to be merged. otherwise I can update this PR and then merge in those changes to fix-codefromfiles

@mmcky
Copy link
Contributor Author

mmcky commented Apr 29, 2021

  • check for other instances of interact in the lectures as there are still javascript objects added

@github-actions github-actions bot temporarily deployed to commit April 29, 2021 10:04 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Apr 29, 2021

@AakashGfude I can confirm if we remove the output from any code-cell that uses interact the theme is rendered in full if that helps with your debugging for quantecon-book-theme

In the short term I think we can accept removing this output and adding in static versions of the code-cell items and leaving the interact versions to mybinder and download notebooks

@github-actions github-actions bot temporarily deployed to commit May 3, 2021 01:06 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented May 3, 2021

This will be merged via #4

@mmcky
Copy link
Contributor Author

mmcky commented Jun 24, 2021

support has been added to the theme. So not considering adjustments at this stage as the default figure shows on the html website.

@mmcky mmcky closed this Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant