-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update made to Markov Chains: Basic Concepts lecture #479
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for taupe-gaufre-c4e660 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jiarui-ZH just some minor comments below
@mmcky, Thank you for the review, please let me know if there is any thing else I need to change! |
thanks @Jiarui-ZH there are some undefined labels that need to be fixed. Once this is building I will do a full review.
|
Hi @mmcky , sorry for the trouble but can you give me a short rundown on the how prf:ref is used? I am still unclear with the referring of markdown |
Hi @Jiarui-ZH here are the docs re: syntax https://sphinx-proof.readthedocs.io/en/latest/syntax.html you essentially use the label that is assigned to the directive item as a reference such as:
|
Everything except for simplifying figures is mentioned in #453 is resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jstac this is ready for your review.
@@ -172,7 +172,7 @@ In particular, $P(i,j)$ is the | |||
|
|||
|
|||
(mc_eg1)= | |||
#### Example 2 | |||
#### Example 2: Unemployment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Jiarui-ZH for opening #502. We can deal with that separately.
@mmcky I have tried to use the sphinix-proof for exampeles however the following warning pops up. I am not sure why this is happening it would be great if you can review this. |
Thanks for reaching out @Jiarui-ZH. The main issues were:
See 088d92b for fixes. |
ahh I see, thank you for the fixes |
@Jiarui-ZH are there any other additions you are planning to make to this PR? |
@mmcky Sorry for the late reply I have been swamped with deferred exams. I have made my final update to this lecture. Please let me know if there is anything else I should update |
for Example 1: Economic states and Example 2: Unemployment which are the only two examples that were referred back to later in the lecture I left them as they are as I thought they are a bit long to be using prf:example and looks neat enough already |
@Jiarui-ZH just organising for this to get merged. |
Resolved! |
* The red, blue and green dots are initial marginal probability distributions $\psi_1, \psi_2, \psi_3$, each of which is represented as a vector in $\mathbb R^3$. | ||
* The transparent dots are the marginal distributions $\psi_i P^t$ for $t = 1, 2, \ldots$, for $i=1,2,3.$. | ||
* The yellow dot is $\psi^*$. | ||
\update_markov_chain_I |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jiarui-ZH is this meant to be a link?
Update to Markov Chains: Basic Concepts lecture (#453 )
Content