Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[french_revolution] [greek_square] [inflation_history] Tom's edits for July #525

Merged
merged 20 commits into from
Aug 15, 2024

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Jul 23, 2024

This PR updates the lecture with edits by @thomassargent30

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit ada343e
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/66bd4dd98726e10008c55426
😎 Deploy Preview https://deploy-preview-525--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mmcky
Copy link
Contributor Author

mmcky commented Jul 23, 2024

@HumphreyYang would you mind to review the merge conflicts that are being reported.

Copy link

github-actions bot commented Jul 23, 2024

@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 11:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 11:40 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 19:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 23, 2024 19:47 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 01:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 01:05 Inactive
@HumphreyYang HumphreyYang changed the title [french revolution] Tom's edits for July [french revolution] [greek_square] [inflation_history] Tom's edits for July Jul 24, 2024
@HumphreyYang HumphreyYang changed the title [french revolution] [greek_square] [inflation_history] Tom's edits for July [french_revolution] [greek_square] [inflation_history] Tom's edits for July Jul 24, 2024
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 01:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 01:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 01:52 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 06:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 24, 2024 07:01 Inactive
@HumphreyYang
Copy link
Collaborator

Hi @mmcky,

I just made some small changes to fix very minor typos and make some symbols closer to the style guide.

I think it is ready for your review and merge.

Many thanks in advance.

@github-actions github-actions bot temporarily deployed to pull request July 25, 2024 08:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 25, 2024 08:33 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 25, 2024 23:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 25, 2024 23:29 Inactive
@HumphreyYang HumphreyYang marked this pull request as ready for review July 26, 2024 00:42
Copy link
Contributor Author

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HumphreyYang just three questions.


A striking feature of the graph is what we'll nick name a **law of gravity** for taxes and expenditures.
A striking feature of the graph is what we'll lagel a *law of gravity* between tax collections and government expenditures.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HumphreyYang should this be label or show?

lectures/french_rev.md Outdated Show resolved Hide resolved
lectures/french_rev.md Outdated Show resolved Hide resolved
@HumphreyYang
Copy link
Collaborator

Many thanks @mmcky, just updated based on your review.

@github-actions github-actions bot temporarily deployed to pull request August 15, 2024 00:32 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 15, 2024 00:43 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 15, 2024 00:46 Inactive
@mmcky
Copy link
Contributor Author

mmcky commented Aug 15, 2024

thanks @HumphreyYang this is building now so I will merge.

@mmcky mmcky merged commit b7730c6 into main Aug 15, 2024
7 checks passed
@mmcky mmcky deleted the tom_july branch August 15, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants