Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: pickups from live lecture #542

Merged
merged 3 commits into from
Aug 1, 2024
Merged

FIX: pickups from live lecture #542

merged 3 commits into from
Aug 1, 2024

Conversation

mmcky
Copy link
Contributor

@mmcky mmcky commented Aug 1, 2024

  • fixes the $\theta$ typo
  • improve labelling on violin plots comparing Amazon and Costco (@longye-tian would you have time to look at this?)

Copy link

netlify bot commented Aug 1, 2024

Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit c550a03
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/66ab5eb58c805e0008e3104f
😎 Deploy Preview https://deploy-preview-542--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Aug 1, 2024

@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 09:31 Inactive
@mmcky mmcky marked this pull request as ready for review August 1, 2024 09:32
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 09:32 Inactive
@longye-tian longye-tian self-assigned this Aug 1, 2024
This updates the x labels of the violin plot comparing Amazon and Costco.
@longye-tian
Copy link
Collaborator

Hi Matt @mmcky,

I have changed the code for the x-label of the violin plot comparing Amazon and Costco. The new plot is shown below:

violin plot

Best,
Longye

@mmcky
Copy link
Contributor Author

mmcky commented Aug 1, 2024

Love your work @longye-tian.

@jstac this PR picks up on the comments you made in the lecture re: typo and updates to the violin plots.

@mmcky mmcky added the ready label Aug 1, 2024
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request August 1, 2024 10:17 Inactive
@jstac
Copy link
Contributor

jstac commented Aug 1, 2024

Nice work @mmcky and @longye-tian , much appreciated :-)

@jstac jstac merged commit eecca09 into main Aug 1, 2024
7 checks passed
@jstac jstac deleted the lecture-pickups branch August 1, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants