-
-
Notifications
You must be signed in to change notification settings - Fork 53
[likelihood_ratio_processes] Update structure and SyntaxWarnings #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @mmcky, I think the build error is caused by an import naming issue in this PR: This is due to a change in imports in the latest release of Currently, we install the packages using:
so it pull the latest one with naming change. I suggest we temporarily pin an earlier version of Please let me know if that sounds good to you. |
@HumphreyYang which lecture is the install happening? I have added the I will pin to |
@HumphreyYang that seems to fix the execution error. Spot on. Please review and merge when you're ready. |
Many thanks @mmcky! I am doing another set of simulations in this PR. My ETA for the merge is tomorrow morning! |
@HumphreyYang I see this had a green tick but the |
Hi @mmcky, did we pin |
@HumphreyYang I just arrived at the same conclusion. Let me open a quick PR to fix. |
This PR updates the structure of
likelihood_ratio_processes
and fix theSyntaxWarning
across lectures.