Skip to content

[likelihood_ratio_processes] Update structure and SyntaxWarnings #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jul 28, 2025

Conversation

HumphreyYang
Copy link
Collaborator

This PR updates the structure of likelihood_ratio_processes and fix the SyntaxWarning across lectures.

Copy link

github-actions bot commented Jul 27, 2025

@github-actions github-actions bot temporarily deployed to pull request July 27, 2025 13:06 Inactive
@HumphreyYang HumphreyYang reopened this Jul 27, 2025
@github-actions github-actions bot temporarily deployed to pull request July 27, 2025 13:38 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 27, 2025 13:39 Inactive
@HumphreyYang
Copy link
Collaborator Author

HumphreyYang commented Jul 27, 2025

Hi @mmcky,

I think the build error is caused by an import naming issue in this PR:
pyro-ppl/numpyro#2052

This is due to a change in imports in the latest release of jax:
https://github.com/jax-ml/jax/releases/tag/jax-v0.7.0

Currently, we install the packages using:

!pip install numpyro jax

so it pull the latest one with naming change.

I suggest we temporarily pin an earlier version of jax until the issue is fixed upstream, and then revert to the latest version afterward.

Please let me know if that sounds good to you.

@github-actions github-actions bot temporarily deployed to pull request July 27, 2025 16:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 27, 2025 18:21 Inactive
@mmcky
Copy link
Contributor

mmcky commented Jul 28, 2025

Hi @mmcky,

I think the build error is caused by an import naming issue in this PR: pyro-ppl/numpyro#2052

This is due to a change in imports in the latest release of jax: https://github.com/jax-ml/jax/releases/tag/jax-v0.7.0

Currently, we install the packages using:

!pip install numpyro jax

so it pull the latest one with naming change.

I suggest we temporarily pin an earlier version of jax until the issue is fixed upstream, and then revert to the latest version afterward.

Please let me know if that sounds good to you.

@HumphreyYang which lecture is the install happening? I have added the no-execute tag to the jax installs as JAX is setup by our build scripts -- but it is good to have in place to remind others to install those packages (when they download a notebook or use collab).

I will pin to jax==0.6.2 for now.

@github-actions github-actions bot temporarily deployed to pull request July 28, 2025 00:36 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 28, 2025 00:36 Inactive
@mmcky
Copy link
Contributor

mmcky commented Jul 28, 2025

@HumphreyYang that seems to fix the execution error. Spot on.

Please review and merge when you're ready.

@HumphreyYang
Copy link
Collaborator Author

Many thanks @mmcky! I am doing another set of simulations in this PR. My ETA for the merge is tomorrow morning!

@github-actions github-actions bot temporarily deployed to pull request July 28, 2025 11:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 28, 2025 11:45 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 28, 2025 13:57 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 28, 2025 13:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 28, 2025 17:14 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 28, 2025 17:14 Inactive
@HumphreyYang HumphreyYang merged commit 84a6c0c into main Jul 28, 2025
7 checks passed
@HumphreyYang HumphreyYang deleted the likelihood-ratio branch July 28, 2025 23:16
@mmcky mmcky removed the in-work label Jul 29, 2025
@mmcky
Copy link
Contributor

mmcky commented Jul 29, 2025

@HumphreyYang I see this had a green tick but the publish workflow has execution failures.

@HumphreyYang
Copy link
Collaborator Author

Hi @mmcky, did we pin pip install --upgrade "jax[cuda12-local]==0.6.2 in the publishing script?

@mmcky
Copy link
Contributor

mmcky commented Jul 29, 2025

@HumphreyYang I just arrived at the same conclusion. Let me open a quick PR to fix.

@mmcky mmcky mentioned this pull request Jul 29, 2025
3 tasks
@thomassargent30 thomassargent30 restored the likelihood-ratio branch July 29, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants