Fix ar1_bayes lecture style guide compliance #593
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reek letters Co-authored-by: mmcky <8263752+mmcky@users.noreply.github.com>
mmcky
reviewed
Sep 7, 2025
Comment on lines
+148
to
+152
| * If we think $y_0$ is drawn from the stationary distribution ${\mathcal N}(0, \frac{\sigma_x^{2}}{1-\rho^2})$, then it is a good idea to use this distribution as $f(y_0)$. | ||
| Why? | ||
| Because $y_0$ contains information about $\rho, \sigma_x$. |
Contributor
There was a problem hiding this comment.
not useful -- part of a list element.
Copilot
AI
changed the title
[WIP] [ar1_bayes] Review lecture for style-guide compliance
Fix ar1_bayes lecture style guide compliance
Sep 7, 2025
Member
|
Hi @mmcky, is this PR based on the main branch? Perhaps we can try to prompt copilot in the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses multiple style guide violations in the
ar1_bayes.mdlecture file to ensure compliance with the QuantEcon style guide.Changes Made
Title Formatting (Title Rule #1)
"Posterior Distributions for AR(1) Parameters"→"Posterior Distributions for AR(1) Parameters"Section Heading Capitalization (Title Rule #2)
"PyMC Implementation"→"PyMC implementation""Numpyro Implementation"→"Numpyro implementation"One-Sentence Paragraphs (Writing Rule #2)
Split 8 multi-sentence paragraphs into individual one-sentence paragraphs, including:
Unicode Greek Letters in Code (Code Rule #4)
Replaced text Greek letters with Unicode symbols throughout all code blocks:
rho→ρin function definitions and variable assignmentssigma→σin function definitions and variable assignmentsApplied consistently across:
ar1_simulate()functionJAX Installation (JAX Rule #1)
jaxfrom!pip install numpyro jaxcommand to avoid installing suboptimaljax[cpu]versionTechnical Impact
All changes preserve the technical accuracy and educational content of the lecture while improving:
The lecture maintains full functionality while adhering to QuantEcon style standards.
Fixes #592.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.