ENH: Basic generic theme - css, js, tpl #697

mmcky · 2019-10-08T02:08:38Z

This PR adds a basic theme for editing tasks.

mmcky

@DrDrij it would be nice to have support for index.html and index_toc.html (for multiple toc elements).

mmcky · 2019-10-08T02:11:56Z

conf.py

+site_title = 'Jupinx Base Theme'
+site_description = ''
+site_keywords = ''
+site_author = ''


what is the difference between this and author?

these should be removed and added to jupyter_ section

mmcky · 2019-10-08T02:12:14Z

conf.py

@@ -68,6 +68,10 @@
 project = 'QuantEcon.lectures-python3'
 copyright = '2019, Thomas J. Sargent and John Stachurski'
 author = 'Thomas J. Sargent and John Stachurski'
+site_title = 'Jupinx Base Theme'
+site_description = ''


should this be = project

…source-py into generic-theme

mmcky · 2019-10-10T08:45:46Z

Thanks @DrDrij.
@jstac here are a few images of the generic-theme that we will deploy with jupinx

Index Page

Lecture Page

@DrDrij all the elements presented are in the RST files now right (i.e. QuantEcon Logo's) are all based on RST inputs?

mmcky · 2019-10-10T08:48:31Z

@mmcky remove the publish theme and add in generic-theme for editing and local compilation.

mmcky · 2019-10-10T23:21:29Z

@DrDrij should support tne status badges for coverage tests? YES and this is already included. Thankd @DrDrij

mmcky · 2019-10-11T09:09:05Z

hey @DrDrij do we still need python-html.tpl?

DrDrij · 2019-10-11T09:15:15Z

Template removed @mmcky

mmcky · 2019-10-11T09:39:34Z

thanks @DrDrij is this asset missing in generic-theme. Is this in img or does it need to be in _static?

<img src="/_static/sloan-logo.png" alt="Sponsored by the Alfred P. Sloan Foundation">

mmcky · 2019-10-11T09:46:03Z

source/rst/index.rst

                    <h2>Web Version</h2>
                    <p>The recommended way to read the lectures</p>
                </a>
            </div>
        </div>
        <ul class="sponsor">
-            <li><a href="http://www.sloan.org/" title="Alfred P. Sloan Foundation"><img src="/_static/sloan_logo.png" alt="Sponsored by the Alfred P. Sloan Foundation"></a></li>
-            <li><a href="https://quantecon.org/"><img src="/_static/img/qe-logo.png" width="150"></a></li>
+            <li><a href="http://www.sloan.org/" title="Alfred P. Sloan Foundation"><img src="/_static/sloan-logo.png" alt="Sponsored by the Alfred P. Sloan Foundation"></a></li>


@DrDrij I think this should be sloan_logo.png with an _ rather than a -

mmcky

hey @DrDrij had a deeper think about the static assets and where they should be kept.

mmcky · 2019-10-11T09:56:44Z

source/rst/index.rst

@@ -23,15 +23,15 @@ Quantitative Economics with Python
            </div>
            <div class="web-version">
                <a href="/index_toc.html">
-                    <span class="thumb"><img src="/_static/img/py-logo.png"></span>


@DrDrij one thought I have had with moving these to the _static folder is that they are not assets that are tracked by sphinx. For example they are not in .. figure or .. image directives. This means they will never be parsed by sphinx and perhaps should remain in the theme folder and copied to static as part of the theme support (as is currently done?). What do you think?

This PR: QuantEcon/sphinxcontrib-jupyter#268 would actually break this setup currently as the static assets contained in the html snippets would never be parsed by sphinx.

@DrDrij what do you think about this?

mmcky · 2019-10-15T01:36:21Z

this PR requires an update to aws management tools to compile with qe theme for publishing.

jstac · 2020-01-28T01:00:07Z

Hi @mmcky, is this still active? Anything I need to do?

mmcky · 2020-03-10T02:39:09Z

this will be implemented in the split of projects #950

DrDrij and others added 5 commits October 2, 2019 14:58

Basic generic theme - css, js, tpl

28e580c

adjust Makefile to allow theme variable overrides

55b21fc

Merge branch 'master' into generic-theme

80af9b6

adjust Makefile to allow theme variable over rides

31eedb4

fix files

96cca29

mmcky commented Oct 8, 2019

View reviewed changes

mmcky added 2 commits October 8, 2019 14:57

restore index files from master branch

71d55b9

Merge branch 'master' into generic-theme

a8ef903

mmcky added the in-work label Oct 9, 2019

DrDrij added 3 commits October 9, 2019 22:11

Add a few styles for homepage, fix site title

1ece401

Merge branch 'generic-theme' of https://github.com/QuantEcon/lecture-…

bba9006

…source-py into generic-theme

Move QE styles to qe.python.css

c8a52af

mmcky added ready in-work and removed in-work ready labels Oct 10, 2019

mmcky and others added 6 commits October 11, 2019 10:50

update latex template name

bff0abb

move theme to minimal folder

2480445

Merge branch 'master' into generic-theme

8197a43

Cleaning theme directory

d6fee93

Move Numfocus badge into source

9ab4fa1

Remove SEO, analytics from base theme

0d8747e

mmcky and others added 2 commits October 11, 2019 20:11

fix path for templates

57805cb

Remove template

51eeb02

update paths for templates

431a998

mmcky commented Oct 11, 2019

View reviewed changes

fix sloan logo name in index

26ee922

mmcky commented Oct 11, 2019

View reviewed changes

ignore quantecon theme

bb9ac80

mmcky removed the in-work label Oct 16, 2019

Put html img assets back into theme #697

9cfafb8

shlff requested review from AakashGfude and DrDrij March 10, 2020 19:39

shlff added the in-work label Mar 10, 2020

mmcky added the on-hold label Mar 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ENH: Basic generic theme - css, js, tpl #697

ENH: Basic generic theme - css, js, tpl #697

mmcky commented Oct 8, 2019

mmcky left a comment

mmcky Oct 8, 2019

mmcky Oct 11, 2019

mmcky Oct 8, 2019

mmcky commented Oct 10, 2019 •

edited

Loading

mmcky commented Oct 10, 2019 •

edited

Loading

mmcky commented Oct 10, 2019 •

edited

Loading

mmcky commented Oct 11, 2019

DrDrij commented Oct 11, 2019

mmcky commented Oct 11, 2019 •

edited

Loading

mmcky Oct 11, 2019

mmcky Oct 11, 2019

mmcky left a comment

mmcky Oct 11, 2019

mmcky Oct 15, 2019

mmcky commented Oct 15, 2019

jstac commented Jan 28, 2020

mmcky commented Mar 10, 2020

ENH: Basic generic theme - css, js, tpl #697

Are you sure you want to change the base?

ENH: Basic generic theme - css, js, tpl #697

Conversation

mmcky commented Oct 8, 2019

mmcky left a comment

Choose a reason for hiding this comment

mmcky Oct 8, 2019

Choose a reason for hiding this comment

mmcky Oct 11, 2019

Choose a reason for hiding this comment

mmcky Oct 8, 2019

Choose a reason for hiding this comment

mmcky commented Oct 10, 2019 • edited Loading

Index Page

TOC

Lecture Page

mmcky commented Oct 10, 2019 • edited Loading

mmcky commented Oct 10, 2019 • edited Loading

mmcky commented Oct 11, 2019

DrDrij commented Oct 11, 2019

mmcky commented Oct 11, 2019 • edited Loading

mmcky Oct 11, 2019

Choose a reason for hiding this comment

mmcky Oct 11, 2019

Choose a reason for hiding this comment

mmcky left a comment

Choose a reason for hiding this comment

mmcky Oct 11, 2019

Choose a reason for hiding this comment

mmcky Oct 15, 2019

Choose a reason for hiding this comment

mmcky commented Oct 15, 2019

jstac commented Jan 28, 2020

mmcky commented Mar 10, 2020

mmcky commented Oct 10, 2019 •

edited

Loading

mmcky commented Oct 10, 2019 •

edited

Loading

mmcky commented Oct 10, 2019 •

edited

Loading

mmcky commented Oct 11, 2019 •

edited

Loading