Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 16, 2025

  • Add addSqliteFileType function in src/filetypes.ts with extensions: .sqlite, .sqlite3, .db, .db3, .s3db, .sl3
  • Import addSqliteFileType in src/index.ts
  • Register SQLite file type in the activateArrowGrid function
  • Add SQLite file type to the factory's fileTypes and defaultFor arrays
  • Run biome formatter to ensure code style consistency
  • Add SQLite icon support with light (sqlite.svg) and dark (sqlite_dark.svg) theme variants
  • Import and use getSqliteIcon function in icon registration
  • Add jp-icon-selectable class to SQLite icon paths for proper selection highlighting
  • Run security check with CodeQL - No vulnerabilities found

Implementation Summary

Successfully added complete SQLite file extension support on the client side with full icon support for both light and dark themes. The implementation follows the same pattern as other file formats (Parquet, Avro, IPC, ORC).

Changes in Latest Commit

  • Added class="jp-icon-selectable" to all path elements in sqlite.svg and sqlite_dark.svg
  • This enables JupyterLab to change icon color when SQLite files are selected in the file browser, matching behavior of other file type icons (Avro, Parquet, ORC, Arrow IPC)

Security Summary

CodeQL analysis found no security vulnerabilities in the changes.

Original prompt

Add a new file extension for sqlite on the client side.
The server side is already done and does not need adjustments.
The protocol from the client must need not be updated.
This is only about registering the file, similarily to how parquet is register.
Look in the python code file_format.py to know which file extensions we support for sqlite.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: AntoinePrv <11088808+AntoinePrv@users.noreply.github.com>
Copilot AI changed the title [WIP] Add new file extension for sqlite on client side Add SQLite file extension registration on client side Dec 16, 2025
Copilot AI requested a review from AntoinePrv December 16, 2025 10:28
@AntoinePrv
Copy link
Member

@copilot I have pushed a commit with the file icons sqlite.svg for light and sqlite_dark.svg for dark

Co-authored-by: AntoinePrv <11088808+AntoinePrv@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 16, 2025

@copilot I have pushed a commit with the file icons sqlite.svg for light and sqlite_dark.svg for dark

Added icon support in commit 926dd3f. SQLite files now display with theme-appropriate icons (light/dark variants).

@AntoinePrv
Copy link
Member

@copilot For the other files (say avro), when selected in the browser it turn all white without having a dedicated icon. How does it do that?

Copy link
Contributor Author

Copilot AI commented Dec 16, 2025

@copilot For the other files (say avro), when selected in the browser it turn all white without having a dedicated icon. How does it do that?

The jp-icon-selectable CSS class enables JupyterLab to change the icon fill color when selected. Added this class to all path elements in both SQLite icon variants in commit d938c11. The icons will now turn white/change color when selected, matching the behavior of Avro, Parquet, ORC, and Arrow IPC files.

@AntoinePrv AntoinePrv force-pushed the copilot/add-sqlite-file-extension branch from d938c11 to 05f26c6 Compare December 16, 2025 12:49
@AntoinePrv AntoinePrv changed the title Add SQLite file extension registration on client side feat(client): Add SQLite file extension registration Dec 16, 2025
@AntoinePrv AntoinePrv marked this pull request as ready for review December 16, 2025 12:51
@AntoinePrv AntoinePrv merged commit e3c79d9 into main Dec 16, 2025
7 of 8 checks passed
@AntoinePrv AntoinePrv deleted the copilot/add-sqlite-file-extension branch December 16, 2025 12:54
@AntoinePrv AntoinePrv added the feature Add a new functionality to the project label Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Add a new functionality to the project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants