Skip to content

fix(client): Fix row chunk default size #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AntoinePrv merged 1 commit into from
Dec 29, 2025
Merged

fix(client): Fix row chunk default size #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export class ArrowModel extends DataModel {
super();

this._loadingParams = {
rowChunkSize: 100,
rowChunkSize: 256,
colChunkSize: 24,
loadingRepr: "",
nullRepr: "",
Expand Down Expand Up @@ -198,6 +198,10 @@ export class ArrowModel extends DataModel {
factors: Required<ArrowModel.PrefetchFactors> = { rowPrefetchFactor: 1, colPrefetchFactor: 1 },
) {
const { chunkRowIdx, chunkColIdx } = chunkIdx;
// If a mulitpliying factor is used, we store the chunk in multiple places so that it can
// be found in constant time.
// Since the chunk stores its start row/col it does not matter on which row the chunk starts
// as long as it contains the expected data.
for (let r = 0; r < factors.rowPrefetchFactor; r++) {
for (let c = 0; c < factors.colPrefetchFactor; c++) {
this._chunks.set({ chunkRowIdx: chunkRowIdx + r, chunkColIdx: chunkColIdx + c }, data);
Expand Down Expand Up @@ -235,6 +239,8 @@ export class ArrowModel extends DataModel {

let promise = Promise.resolve();

// This chunk uses the row prefetching multiplier and runs first as we estimate
// scrolling horizontally is more likely.
const nextRowsChunkIdx: ChunkMap.ChunkIdx = { chunkRowIdx: chunkRowIdx + 1, chunkColIdx };
if (!this._chunks.has(nextRowsChunkIdx) && this._chunks.chunkIsValid(nextRowsChunkIdx)) {
const rowFactors = {
Expand All @@ -249,6 +255,8 @@ export class ArrowModel extends DataModel {
);
}

// This chunk uses the column prefetching multiplier and waits for the previous to complete
// before running to reduce load on the server.
const nextColsChunkIdx: ChunkMap.ChunkIdx = { chunkRowIdx, chunkColIdx: chunkColIdx + 1 };
if (!this._chunks.has(nextColsChunkIdx) && this._chunks.chunkIsValid(nextColsChunkIdx)) {
const colFactors = {
Expand Down
Loading