feat: add branch info and flag to status subcommand #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
reviewed
Jun 26, 2025
src/wrapper/refs_wrapper.cpp
Outdated
| p_resource=nullptr; | ||
| } | ||
|
|
||
| const char* reference_wrapper::get_ref_name(const repository_wrapper& rw) |
There was a problem hiding this comment.
I think this should return a std::string rather than const char*. When the reference_wrapper goes out of scope at the end of this function, we can't be sure if the const char* returned from git_reference_shorthand is valid or not without checking the libgit2 code or documentation. If we return a string then we're taking a copy and this is guaranteed to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the branch information to the status subcommand when in long format (e.g.
On branch main) and in short format when the branch flag is used (e.g.## main).