Remove tab #117
Merged
Remove tab #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
brichet
reviewed
Jul 10, 2023
| @@ -131,6 +131,14 @@ export class GlueSessionSharedModel | |||
| }, false); | |||
| } | |||
|
|
|||
| removeTab(name: string): void { | |||
There was a problem hiding this comment.
Probably in a follow up PR, but the viewers of the tab could also be deleted to clean the session file.
Maybe we can open an issue on it.
There was a problem hiding this comment.
Indeed I wanted to do it in this PR, but it needs more changes in the YDoc structure since we need to keep track of the viewers in a YMap
|
Are the changes on
|
Idk, I did not touch on anything in the package.json. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.