Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an arbitrary directory root #17

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Conversation

DenisaCG
Copy link
Member

@DenisaCG DenisaCG commented Jun 5, 2024

Added a root parameter to the authentication plugin - a variable containing the path to a directory within the bucket, which will act as a new root of the drive inside the FileBrowser. If left empty, the root will be considered as the default one (the directory holding the contents of the entire bucket).

When being set for the Drive object, the root is automatically formatted accordingly with the use of a helper function, which makes sure all leading and trailing / are eliminated and the path leads to an existing directory within the chosen bucket. If the path is faulty, theroot becomes the default one.

Updated the logic of all existing functionalities to consider the root when extracting the path, if it exists, and added a new root parameter in the dialog box for switching to another drive (if the parameter is left empty, the default one is considered).

@DenisaCG DenisaCG self-assigned this Jun 5, 2024
@DenisaCG DenisaCG added the enhancement New feature or request label Jun 5, 2024
@afshin afshin self-requested a review June 13, 2024 13:33
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@afshin afshin merged commit 2add6d4 into QuantStack:main Jun 14, 2024
6 checks passed
@DenisaCG DenisaCG deleted the arbitraryRoot branch June 14, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants