Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some dependencies optional #98

Open
jtpio opened this issue Jun 16, 2021 · 0 comments
Open

Make some dependencies optional #98

jtpio opened this issue Jun 16, 2021 · 0 comments

Comments

@jtpio
Copy link
Member

jtpio commented Jun 16, 2021

In the main plugin entrypoint, a couple of dependencies are marked as requires:

jupyterlab-drawio/src/index.ts

Line 68 in 938cc92

requires: [IFileBrowserFactory, ILayoutRestorer, IMainMenu, ICommandPalette],

Ideally ILayoutRestorer, ILayoutRestorer and ICommandPalette could be set as optional instead, which would make using jupyterlab-drawio in other lab distributions easier.
hbcarlos added a commit that referenced this issue Jun 28, 2021
@hbcarlos
Makes drawio collaborative sharing the mxCells as string, and makes I…
864805d 
…CommandPalette an optional dependency (see #98)
hbcarlos added a commit that referenced this issue Jun 28, 2021
@hbcarlos
Makes drawio collaborative sharing the mxCells as string, and makes I…
9ad0a30 
…CommandPalette an optional dependency (see #98)
@jtpio jtpio mentioned this issue Jul 22, 2021
Open
hbcarlos added a commit that referenced this issue Aug 24, 2021
@hbcarlos
Makes drawio collaborative sharing the mxCells as string, and makes I…
7d94ba0 
…CommandPalette an optional dependency (see #98)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtpio