Implement recursive handling of import #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It also requires the dev version of beniget :-) |
serge-sans-paille
force-pushed
the
feature/recursive-import
branch
2 times, most recently
from
6b33bfe to
e679548
Compare
|
Not mergeable yet: I need to implement support of dependencies in the cache system |
serge-sans-paille
force-pushed
the
feature/recursive-import
branch
from
83dd596 to
b57ec5c
Compare
|
ready for review, cc @JohanMabille and @marimeireles |
serge-sans-paille
force-pushed
the
feature/recursive-import
branch
2 times, most recently
from
6da191b to
f7f7976
Compare
The recursive strategy basically states that if a symbol uses a symbol that uses a symbol that... uses a deprecated symbol, even within a deep module hierarchy, it is deprecated. - it's optional - it's still incompatible with the caching system (no dep handling)
serge-sans-paille
force-pushed
the
feature/recursive-import
branch
2 times, most recently
from
d565692 to
3c30ac1
Compare
When recursive import is activated, a change in an imported file may have an impact on the validity of the cache. To prevent that, we integrate the hash of each imported module to the key. This currently makes the computation much slower, there's probably another way to handle that.
Do not recompute the same key twice, using a key factory. Speedup dependency computation using native ast module and short-circuiting. Minimal documentation.
serge-sans-paille
force-pushed
the
feature/recursive-import
branch
from
3c30ac1 to
5e2d3bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recursive strategy basically states that if a symbol uses a symbol that uses
a symbol that... uses a deprecated symbol, even within a deep module hierarchy,
it is deprecated.