Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt import of check_X_y to comply with scikit-learn 1.6 #96

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

kklein
Copy link
Collaborator

@kklein kklein commented Dec 24, 2024

We used to import check_X_y and check_array from sklearn.base. Since PR 29696 -- released in version 1.6.0 -- these function are no longer available in sklearn.base, but rather only in sklearn.utils.

Checklist

  • Added a CHANGELOG.rst entry

Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.74%. Comparing base (8b371de) to head (41c4189).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   94.73%   94.74%           
=======================================
  Files          15       15           
  Lines        1806     1807    +1     
=======================================
+ Hits         1711     1712    +1     
  Misses         95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kklein kklein merged commit bfaaf5d into main Dec 24, 2024
16 checks passed
@kklein kklein deleted the scikit-1.6 branch December 24, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant