Conversation
pavelzw
commented
Apr 25, 2025
src/unpack.rs
Outdated
Comment on lines
66
to
78
| // HACK: The `Installer` created below, as well as some code in building | ||
| // packages from source will utilize rayon for parallelism. By using rayon | ||
| // it will implicitly initialize a global thread pool. However, uv | ||
| // has a mechanism to initialize rayon itself, which will crash if the global | ||
| // thread pool was already initialized. To prevent this, we force uv the | ||
| // initialize the rayon global thread pool, this ensures that any rayon code | ||
| // that is run will use the same thread pool. | ||
| // | ||
| // One downside of this approach is that perhaps it turns out that we won't need | ||
| // the thread pool at all (because no changes needed to happen for instance). | ||
| // There is a little bit of overhead when that happens, but I don't see another | ||
| // way around that. | ||
| LazyLock::force(&RAYON_INITIALIZE); |
Member
Author
There was a problem hiding this comment.
thanks a lot on your help with this @tdejager!
xref https://github.com/prefix-dev/pixi/blob/4dc02c840d63e75f16a2da6a8fc74a7f67218cb3/src/environment/conda_prefix.rs#L294
delsner
approved these changes
Apr 25, 2025
Member
delsner
left a comment
delsner
left a comment
There was a problem hiding this comment.
Thanks for figuring this out!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
required for #136
Changes
If updating documentation:
Updated documentation in https://github.com/prefix-dev/pixi/blob/main/docs/deployment/pixi_pack.md as well