Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change default manifest path to cwd #99

Merged
merged 3 commits into from
Feb 19, 2025
Merged

fix: Change default manifest path to cwd #99

merged 3 commits into from
Feb 19, 2025

Conversation

delsner
Copy link
Member

@delsner delsner commented Feb 19, 2025 •
edited
Loading

Motivation

Fixes #98.

Changes

The default for the manifest_path variable should be the current working directory, so we can support both, pixi.toml or pyproject.toml.

@delsner delsner self-assigned this Feb 19, 2025
@delsner delsner requested a review from pavelzw as a code owner February 19, 2025 13:22
@delsner delsner mentioned this pull request Feb 19, 2025
Closed
@github-actions github-actions bot added the fix label Feb 19, 2025
@delsner delsner linked an issue Feb 19, 2025 that may be closed by this pull request
pixi-pack 0.3.2 does not support pyproject.toml in certain scenarios #98
Closed
pavelzw
pavelzw approved these changes Feb 19, 2025
View reviewed changes
Copy link
Member

@pavelzw pavelzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a noop technically since we just replace pixi.toml/pyproject.toml with pixi.lock, right?

@delsner delsner enabled auto-merge (squash) February 19, 2025 13:37
@delsner delsner merged commit 717d12e into main Feb 19, 2025
17 checks passed
@delsner delsner deleted the fix-default-manifest branch February 19, 2025 13:41
@BrewTestBot BrewTestBot mentioned this pull request Feb 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelzw pavelzw pavelzw approved these changes

Assignees

@delsner delsner

Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pixi-pack 0.3.2 does not support pyproject.toml in certain scenarios
2 participants
@delsner @pavelzw