Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a QURI Parts converter #210

Merged
merged 15 commits into from
Apr 1, 2023
Merged

Add a QURI Parts converter #210

merged 15 commits into from
Apr 1, 2023

Conversation

kotamanegi
Copy link
Contributor

Hello 👋

In this PR, I added a QURI Parts quantum circuit converter.
Now QuantestPy supports Qiskit, QURI Parts, QASM as input.

Changes for existing code:

  • If Qiskit is not installed, always return False on instance detection instead of raising an error.
  • In the illegal input error of cvt_input_circuit_to_quantestpy_circuit, the error message is changed.

Feel free to edit my code if you find bugs or want to do some refactoring.
Thanks 👍

@junnaka51 junnaka51 self-requested a review February 22, 2023 23:05
Copy link
Contributor

@junnaka51 junnaka51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the test codes checking the equality between QuantestPyCircuit and Qulacs after conversion are valuable and very appreciated 🙇 and the changes in the existing codes seem fairly reasonable.

@junnaka51 junnaka51 requested a review from mitz1012 February 23, 2023 02:50
@mitz1012 mitz1012 merged commit 268d514 into QuantestPy:main Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants