Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CUDA to v 3.6 #72

Merged
merged 4 commits into from
Jan 15, 2022
Merged

update CUDA to v 3.6 #72

merged 4 commits into from
Jan 15, 2022

Conversation

GiggleLiu
Copy link
Member

No description provided.

@GiggleLiu GiggleLiu requested a review from Roger-luo January 14, 2022 22:57
Copy link
Member

@Roger-luo Roger-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run test locally? We don't have GPU CI right now

Project.toml Outdated Show resolved Hide resolved
@@ -83,19 +83,6 @@ end
@test size(res) == (32,)
@test res2 == res

# measure! and reset
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why tests is rm?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because these tests are ill defined. They should not work. Note the previous measurement on operators are not correct.

@GiggleLiu
Copy link
Member Author

tests pass on my local host.

@GiggleLiu GiggleLiu merged commit 86a968a into master Jan 15, 2022
@GiggleLiu GiggleLiu deleted the update-cuda-3.6 branch January 15, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants