Removed unnecessary type parameters and type piracy #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I forgot why I added this patch. If the tests pass locally, I think removing it is better. |
|
In that case don't merge yet. I will check if the tests pass tomorrow when I am back at work and update the PR if they do. |
because it was exactly the same logic as expect(::Scale, ::DensityMatrix)
|
Yup, as expected the tests also still pass after removing |
|
Thank you! I will tag a new version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got some warnings for the mentioned type parameters and about type piracy that is fixed now.
But since
expect(op::Scale, reg::CuDensityMatrix)implements exactly the same logic asexpect(op::Scale, reg::DensityMatrix)inYaoArrayRegister, is it even needed or can it be removed altogether?