Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty static sparse error #20

Merged
merged 3 commits into from
May 22, 2019
Merged

fix empty static sparse error #20

merged 3 commits into from
May 22, 2019

Conversation

Roger-luo
Copy link
Member

@Roger-luo Roger-luo commented May 22, 2019

occasionally causing QuantumBFS/YaoArrayRegister.jl#17 to fail

A = sprand_hermitian(2) # when empty
staticsize(A)

@Roger-luo Roger-luo requested a review from GiggleLiu May 22, 2019 05:38
@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #20 into master will increase coverage by 2.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
+ Coverage    70.8%   72.92%   +2.11%     
==========================================
  Files          12       12              
  Lines         483      565      +82     
==========================================
+ Hits          342      412      +70     
- Misses        141      153      +12
Impacted Files Coverage Δ
src/staticize.jl 72.72% <100%> (+2.72%) ⬆️
src/linalg.jl 69.34% <0%> (+2.03%) ⬆️
src/arraymath.jl 71.73% <0%> (+5.07%) ⬆️
src/conversions.jl 54.11% <0%> (+23.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef045d2...5bf152f. Read the comment docs.

@GiggleLiu GiggleLiu merged commit 8934afc into master May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants