Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add randn! and rand! and zero #23

Merged
merged 1 commit into from
Oct 7, 2019
Merged

add randn! and rand! and zero #23

merged 1 commit into from
Oct 7, 2019

Conversation

GiggleLiu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 18, 2019

Codecov Report

Merging #23 into master will increase coverage by 0.36%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   74.43%   74.79%   +0.36%     
==========================================
  Files          12       12              
  Lines         485      492       +7     
==========================================
+ Hits          361      368       +7     
  Misses        124      124
Impacted Files Coverage Δ
src/PermMatrix.jl 68.18% <100%> (+1.51%) ⬆️
src/linalg.jl 84.4% <100%> (+0.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42bf27c...f8d81af. Read the comment docs.

@Roger-luo
Copy link
Member

I think from now on, we need to add version compat to these pirate changes, or it might cause conflict in future Julia versions. I'll do it myself this time.

@Roger-luo Roger-luo merged commit e16b809 into master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants