Skip to content
This repository has been archived by the owner on Dec 18, 2021. It is now read-only.

Fix measure dispatch #22

Merged
merged 3 commits into from
Dec 7, 2019
Merged

Fix measure dispatch #22

merged 3 commits into from
Dec 7, 2019

Conversation

GiggleLiu
Copy link
Member

@GiggleLiu GiggleLiu commented Dec 7, 2019

Unify interfaces
measure!, measure_remove! and measure_resetto! (or previous measure_collapseto!).

To
measure!(::NoPostProcess, ...), measure!(::RemoveMeasured, ...) and measure!(::ResetTo, ...)

@GiggleLiu GiggleLiu requested a review from Roger-luo December 7, 2019 16:02
@codecov
Copy link

codecov bot commented Dec 7, 2019

Codecov Report

Merging #22 into master will decrease coverage by 1.26%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   53.62%   52.36%   -1.27%     
==========================================
  Files          11       11              
  Lines         248      254       +6     
==========================================
  Hits          133      133              
- Misses        115      121       +6
Impacted Files Coverage Δ
src/abstract_register.jl 7.84% <0%> (-1.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa88376...06cd2c6. Read the comment docs.

@GiggleLiu
Copy link
Member Author

Since CI passes, I will merge it first. We can fix it later. This will fix #21

@GiggleLiu GiggleLiu merged commit d907f45 into master Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant